vmx: Replace pointless test-then-set with set.
authorKeir Fraser <keir@xensource.com>
Sat, 12 May 2007 11:46:26 +0000 (12:46 +0100)
committerKeir Fraser <keir@xensource.com>
Sat, 12 May 2007 11:46:26 +0000 (12:46 +0100)
Spotted by Eddie Dong.
Signed-off-by: Keir Fraser <keir@xensource.com>
xen/arch/x86/hvm/vmx/vmx.c

index ea20a8cfd2696909b814451f831968787d3462b5..dfc4ad64316aebd8151beb1f9e7d6e5c512b3d2e 100644 (file)
@@ -101,12 +101,11 @@ static void vmx_save_host_msrs(void)
         rdmsrl(msr_index[i], host_msr_state->msrs[i]);
 }
 
-#define WRITE_MSR(address)                                                  \
-        guest_msr_state->msrs[VMX_INDEX_MSR_ ## address] = msr_content;     \
-        if ( !test_bit(VMX_INDEX_MSR_ ## address, &guest_msr_state->flags) )\
-            set_bit(VMX_INDEX_MSR_ ## address, &guest_msr_state->flags);    \
-        wrmsrl(MSR_ ## address, msr_content);                               \
-        set_bit(VMX_INDEX_MSR_ ## address, &host_msr_state->flags);         \
+#define WRITE_MSR(address)                                              \
+        guest_msr_state->msrs[VMX_INDEX_MSR_ ## address] = msr_content; \
+        set_bit(VMX_INDEX_MSR_ ## address, &guest_msr_state->flags);    \
+        wrmsrl(MSR_ ## address, msr_content);                           \
+        set_bit(VMX_INDEX_MSR_ ## address, &host_msr_state->flags);     \
         break
 
 static inline int long_mode_do_msr_read(struct cpu_user_regs *regs)